WIP: Polling the parent process on Windows#192
Open
mrkn wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adds an initial Windows-specific path for the “parent process poller” in IRuby::Kernel, intended to support interrupt-based shutdown detection on Windows while preserving the existing Unix polling behavior.
Changes:
- Introduces Windows branching in
init_parent_process_poller, readingJPY_EVENT_INTERRUPTand calling a new Windows poller method. - Moves the
parent_pid > 1guard to only apply to the non-Windows branch. - Adds a new (currently placeholder)
start_parent_process_pollar_windowsmethod.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
179
to
183
| case RUBY_PLATFORM | ||
| when /mswin/, /mingw/ | ||
| # TODO | ||
| interrupt_handle = Integer(ENV.fetch('JPY_EVENT_INTERRUPT', 0)) | ||
| @parent_poller = start_parent_process_pollar_windows(parent_pid, interrupt_handle) | ||
| else |
Comment on lines
+207
to
+211
| def start_parent_process_pollar_windows(parent_handle, interrupt_handle) | ||
| Thread.start do | ||
| IRuby.logger.warn("parent process poller thread started.") | ||
| # TODO | ||
| end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.