fix(demo): stub @x402/* missing transitive deps from coinbase-sdk#54
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
shawnmuggle
approved these changes
Jul 18, 2026
shawnmuggle
left a comment
Member
There was a problem hiding this comment.
Reviewed (two-pass: deep review + independent second pass). No P0/P1 blockers — the change only affects the demo app's webpack build, stubs are verified complete and minimal for the cdp-sdk import graph, and no runtime path in the demo can reach the stubbed modules (no x402 usage anywhere in the repo; baseAccount wallet config is commented out). LGTM.
Non-blocking P2 notes:
- Redundant entries:
"@x402/evm": falsealready prefix-matches@x402/evm/upto/clientand@x402/evm/exact/client(webpack non-$alias keys cover subpaths), so those two lines are dead config. Could be collapsed to just@x402/core,@x402/evm,@x402/svmfor forward-coverage of any future specifier under those scopes. - Currently inert with the committed lockfile: pnpm-lock pins
@coinbase/cdp-sdk@1.51.2, which has zero@x402/*imports — the error only appears when resolution floats to ≥1.52 (declared^1.0.0by@base-org/account). The stub is forward-compatible so this is fine; a pnpm override pinning cdp-sdk would be the alternative root-cause fix. - Turbopack caveat: these aliases live in the
webpack()callback only. If--turbopackis ever added to dev/build scripts, the stubs silently stop applying (turbopack needsturbopack.resolveAlias) and the module-not-found error returns. - Error-message tradeoff: alias
falsemakes cdp-sdk's lazyimport("@x402/...")succeed with an empty module, bypassing the SDK's intentional "install @x402 peer deps" error wrapper — ifsignX402Payment()were ever called it would throw an opaque TypeError instead. Unreachable in this demo today.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.