Skip to content

fix(demo): stub @x402/* missing transitive deps from coinbase-sdk#54

Merged
akbarsaputrait merged 1 commit into
masterfrom
fix/x402-missing-deps
Jul 19, 2026
Merged

fix(demo): stub @x402/* missing transitive deps from coinbase-sdk#54
akbarsaputrait merged 1 commit into
masterfrom
fix/x402-missing-deps

Conversation

@akbarsaputrait

Copy link
Copy Markdown
Member

No description provided.

@vercel

vercel Bot commented Jul 18, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
intent-example Ready Ready Preview, Comment Jul 18, 2026 3:12pm

Request Review

@shawnmuggle shawnmuggle left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed (two-pass: deep review + independent second pass). No P0/P1 blockers — the change only affects the demo app's webpack build, stubs are verified complete and minimal for the cdp-sdk import graph, and no runtime path in the demo can reach the stubbed modules (no x402 usage anywhere in the repo; baseAccount wallet config is commented out). LGTM.

Non-blocking P2 notes:

  1. Redundant entries: "@x402/evm": false already prefix-matches @x402/evm/upto/client and @x402/evm/exact/client (webpack non-$ alias keys cover subpaths), so those two lines are dead config. Could be collapsed to just @x402/core, @x402/evm, @x402/svm for forward-coverage of any future specifier under those scopes.
  2. Currently inert with the committed lockfile: pnpm-lock pins @coinbase/cdp-sdk@1.51.2, which has zero @x402/* imports — the error only appears when resolution floats to ≥1.52 (declared ^1.0.0 by @base-org/account). The stub is forward-compatible so this is fine; a pnpm override pinning cdp-sdk would be the alternative root-cause fix.
  3. Turbopack caveat: these aliases live in the webpack() callback only. If --turbopack is ever added to dev/build scripts, the stubs silently stop applying (turbopack needs turbopack.resolveAlias) and the module-not-found error returns.
  4. Error-message tradeoff: alias false makes cdp-sdk's lazy import("@x402/...") succeed with an empty module, bypassing the SDK's intentional "install @x402 peer deps" error wrapper — if signX402Payment() were ever called it would throw an opaque TypeError instead. Unreachable in this demo today.

@akbarsaputrait
akbarsaputrait merged commit 043888d into master Jul 19, 2026
4 of 5 checks passed
@akbarsaputrait
akbarsaputrait deleted the fix/x402-missing-deps branch July 19, 2026 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants