BinaryCIF and mmJSON input support for Rosetta.#717
Open
roccomoretti wants to merge 11 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for BinaryCIF and mmJSON input file formats.
The actual file loading changes are in
source/src/utility/gemmi_util.ccandsource/src/core/import_pose/import_pose.cc.The msgpack support with the nlohmann JSON parser needed us to upgrade to the most recent version. This resulted in a cleanup of a number of different JSON-using files (primarily because of changes in namespace usage.) This is the bulk of the file changes.
BinaryCIF is a more complicated format than I originally anticipated. The decoding code probably needs some cleanup and better error handling, but it's working well enough at the moment to load a few example entries identically to the CIF formatted versions.
There's also a bug fix with respect to the extension-based file format detection.
Note: There's no output support for either format. Use plain mmCIF (
-out:mmCIF) instead.