Steam no EAC launch + fix Epic launch#172
Open
VirxEC wants to merge 8 commits into
Open
Conversation
Bump version to v5.0.0-rc.15.
Delete old launch log before reading and launch the game directly via its executable path instead of wrapping with cmd.exe.
NicEastvillage
requested changes
Jun 26, 2026
NicEastvillage
left a comment
NicEastvillage
left a comment
Contributor
There was a problem hiding this comment.
Nice. Environment variables were the next avenue I was going to investigate. Happy to see it is so simple here.
I tested Steam launching on Windows, and it works, as long as Steam is already running. What launcher/OS combinations did you test?
Move WinProcArgs and WinReadLog into the LaunchManager directory. Rename ProcessCommandLine to ProcArgs. Rename WinReadLog to ReadLog and make it static. Update all references.
Improve argument parsing to avoid false positives from empty command lines Downgrade argument retrieval failure log from Error to Warning
Collaborator
Author
|
(System time was off, made the commits appear in the future, fixed) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Steam – No EAC (Windows + Linux)
This version successfully loads my player settings and stuff unlike the Epic no EAC launch and has replaced the only-with-EAC launch we had previously.
Steam.Windows.cs): Replaces-applaunchwith direct executable launch. Discovers the Rocket League install path by reading Steam library folders from the registry andlibraryfolders.vdf. SetsSteamAppId/SteamGameIdenvironment variables so Steamworks logs us in.Steam.Linux.cs): New implementation that discovers Steam roots via symlinks, XDG paths, Flatpak/Snap, and PATH. Finds the installed Rocket League and the configured (or newest) Proton version, then launches the game viaproton runwith the necessarySTEAM_COMPAT_*environment variables.config.vdffor the configured compatibility tool, falls back to the numerically newest Proton installation, with special handling for Hotfix/Experimental builds.Epic – Launch fixes (Windows)
Still doesn't load player settings beyond the username, but should launch much more reliably. It should be noted that player settings ARE loaded when launching Epic RL without EAC from the launcher manually, so we're probably missing something.
Epic.Windows.cs: Refactored to delete the old launch log before starting, read both the executable path and auth arguments fromWinReadLog.GetGamePathAndAuth(), and launch the game executable directly instead of wrapping withcmd.exe /c.WinReadLog.cs: AddedDeleteLog(),FileShare.ReadWritefor concurrent access, andIOExceptionhandling to retry while the log is still being written.Both Steam and Epic now default to launching without EAC which is probably a good step towards #156
Bumped version to
v5.0.0-rc.15