fix(events): a bunch of small fixes#110
Merged
Merged
Conversation
Makes it so the player list in the menu is filtered by those who can host map parties (`community.event` as per MapPartyFeature) instead of `community.staff`. Signed-off-by: TTtie <me@tttie.cz>
…event type Creating an event using `/event create` without a type passed in throws a NPE in MapPartyFeature#create due to null event type. This commit fixes both the NPE and makes the event type required to ensure consistency between the event GUI and event commands. Signed-off-by: TTtie <me@tttie.cz>
Makes the preset name in /event preset a required parameter as it doesn't make sense to create against a null preset. Signed-off-by: TTtie <me@tttie.cz>
This commit fixes an issue where event hosts that were online couldn't be removed from the event host list due to them being resolved to a UUID. This fix is suboptimal, but given that this doesn't happen often, it is probably sufficient. Signed-off-by: TTtie <me@tttie.cz>
applenick
approved these changes
Jun 22, 2026
applenick
left a comment
applenick
left a comment
Member
There was a problem hiding this comment.
Nice fixes! Thanks for looking into these.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a few small issues that have popped up while I was playing around with
/eventlocally./event createand/event presetrequire the type name (or the preset name respectively), preventing NPEs when no arguments are supplied