Coerce option values to string in shQuote()#270
Open
Arm4g3ddon wants to merge 1 commit into
Open
Conversation
shQuote called .replace() directly on the value, which throws 'TypeError: s.replace is not a function' when an option value is a number instead of a string. Wrap it in String() so numeric values are handled too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #269.
shQuote()called.replace()straight on the value, which throwsTypeError: s.replace is not a functionfor numeric option values. Wrapping the value inString()handles numbers (and anything else non-string) while leaving normal string values unchanged.