Skip to content

[18.0][FIX] web_dialog_size: fix infinite RPC retry loop#3598

Merged
OCA-git-bot merged 1 commit into
OCA:18.0from
Tekfor-cloud:18.0-web_dialog_size-infinite-loop
Jun 25, 2026
Merged

[18.0][FIX] web_dialog_size: fix infinite RPC retry loop#3598
OCA-git-bot merged 1 commit into
OCA:18.0from
Tekfor-cloud:18.0-web_dialog_size-infinite-loop

Conversation

@Lukwos

@Lukwos Lukwos commented Jun 25, 2026

Copy link
Copy Markdown

Port of this issue : #3523

@Lukwos

Lukwos commented Jun 25, 2026

Copy link
Copy Markdown
Author

@pedrobaeza

@pedrobaeza pedrobaeza added this to the 18.0 milestone Jun 25, 2026
import {SelectCreateDialog} from "@web/views/view_dialogs/select_create_dialog";
import {patch} from "@web/core/utils/patch";
import {useService} from "@web/core/utils/hooks";
import { Component, onMounted, onWillRender } from "@odoo/owl";

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why all of these changes?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, didn't see my formatter doing those changes. Fixed now

@Lukwos Lukwos force-pushed the 18.0-web_dialog_size-infinite-loop branch from eb615bd to c0fd91d Compare June 25, 2026 08:14
@pedrobaeza

Copy link
Copy Markdown
Member

Please follow commit message guidelines.

@Lukwos Lukwos force-pushed the 18.0-web_dialog_size-infinite-loop branch from c0fd91d to 6f1f97a Compare June 25, 2026 08:26
@pedrobaeza

Copy link
Copy Markdown
Member

pre-commit is complaining about the formatting.

@Lukwos Lukwos force-pushed the 18.0-web_dialog_size-infinite-loop branch from 6f1f97a to 2f3dd99 Compare June 25, 2026 09:50
@pedrobaeza

Copy link
Copy Markdown
Member

/ocabot merge patch

@OCA-git-bot

Copy link
Copy Markdown
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 18.0-ocabot-merge-pr-3598-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit b7f35d0 into OCA:18.0 Jun 25, 2026
13 of 14 checks passed
@OCA-git-bot

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 428a08d. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants