Fix compile warnings in mantis-server-agent module#864
Open
mliem2k wants to merge 1 commit into
Open
Conversation
Context: mantis-server-agent module update for removing warnings, refer issue Netflix#393. Addresses: - anonymous Thread subclass replaced with a method reference (MantisAgent) - anonymous ListenerCallQueue.Event implementations use diamond operator instead of a redundant explicit type argument (TaskExecutor) - filled in an empty @return javadoc tag (Hardware)
mliem2k
requested review from
Andyz26,
calvin681,
dtrager02,
fdc-ntflx,
hellolittlej and
james-lubin
as code owners
July 12, 2026 23:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
mantis-server-agent module update for removing warnings, refer issue #393.
Change set:
MantisAgent: anonymousThreadsubclass overriding onlyrun()replaced withnew Thread(this::shutdown).TaskExecutor: anonymousListenerCallQueue.Event<Listener>implementations now use the diamond operator instead of a redundant explicit type argument.Hardware: filled in an empty@returnjavadoc tag ongetSizeOfDisk().No logic changes, no public interface changes.
Checklist
./gradlew buildcompiles code correctly./gradlew testpasses all tests