fix(when_any): guard stop callback against inline completion destroying the opstate#2115
Open
nebkat wants to merge 1 commit into
Open
fix(when_any): guard stop callback against inline completion destroying the opstate#2115nebkat wants to merge 1 commit into
nebkat wants to merge 1 commit into
Conversation
nebkat
changed the title
…ng the opstate If every child completes set_stopped() synchronously from inside __stop_source_.request_stop() (senders that complete inline from their stop callbacks), __count_ reaches zero and the receiver is completed -- destroying the operation state, including __stop_source_, while request_stop() is still iterating its callback list. The subsequent relock then spins on freed memory. Adopt __when_all's rug-pull guard: temporarily increment __count_ around request_stop() in the stop callback and arrive afterwards, so completion is deferred until the callback has returned.
nebkat
force-pushed
the
fix-when-any-inline-completion
branch
from
fc40409 to
1649cf3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If every child completes
set_stopped()synchronously from inside__stop_source_.request_stop()(senders that complete inline from their stop callbacks),__count_reaches zero and the receiver is completed -destroying the operation state, including__stop_source_, whilerequest_stop()is still iterating its callback list. The subsequent relock then spins on freed memory.Adopt
__when_all's rug-pull guard: temporarily increment__count_aroundrequest_stop()in the stop callback and arrive afterwards, so completion is deferred until the callback has returned.https://godbolt.org/z/sPWeEEesE