CMake: fix detection of commit hook when running in git worktree#3407
Open
jdtournier wants to merge 2 commits into
Open
CMake: fix detection of commit hook when running in git worktree#3407jdtournier wants to merge 2 commits into
jdtournier wants to merge 2 commits into
Conversation
|
clang-tidy review says "All clean, LGTM! 👍" |
clang-format is no longer the exclusive pre-commit hook.
|
clang-tidy review says "All clean, LGTM! 👍" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running in a git worktree,
.gitis a file (not a folder) containing the location of the main repo. This causes the detection of the hook to fail, which issues a warning when running cmake even if the hook is installed. This commit uses a more robust way of determining the location of the main git repo (usinggit --rev-parse --git-common-dir).