Upgrade POC Elastic Stack to 9.4.2#75
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5ecb390ab4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| for path in repo.rglob('*'): | ||
| if path.is_dir() or '.git' in path.parts or path.suffix in {'.pyc', '.pyo'}: | ||
| continue | ||
| try: | ||
| text = path.read_text(errors='ignore') |
There was a problem hiding this comment.
Limit stale-version scan to tracked files
This repo-wide rglob also reads gitignored/untracked files, so the test fails for a documented local workflow if a developer has an older .env.poc.local with ELK_VERSION=9.4.0 (or any local notes/cache/venv file containing the stale tokens), even though the committed files are correct. Since .env.poc.local is explicitly gitignored and called out in the POC docs as an optional local override, this check should restrict itself to tracked files or exclude ignored paths.
Useful? React with 👍 / 👎.
Motivation
9.4.2to match current POC images and avoid mixed-version confusion.ELK_VERSIONvariable so future bumps are one-line changes."latest"-related Fleet error.Description
ELK_VERSION=9.4.2in.env.pocand addedELK_VERSION=9.4.2to.env.example.ELK_VERSIONvariable indocker-compose.poc.ymlanddocker-compose.ymlso Elasticsearch, Kibana, Fleet Server and Elastic Agent use${ELK_VERSION:-9.4.2}.APM_VER,DOCKER_VER, etc.) before POSTingpackage_policies, avoiding literal"latest"in policy bodies.9.4.2, added a smalldocker manifest inspectchecklist indocs/poc-setup.md, added an explicit upgrade note instructing users to run./scripts/demo_reset.sh,docker compose -f docker-compose.poc.yml --env-file .env.poc pull, and./scripts/demo_up.sh, and adjusted OTel/README compatibility notes and resource table.config/otel-collector-poc.yamlcomment, tweakedrequirements.txtcomment, and added focused validation tests intests/test_poc_pipeline.pyto ensure consistentELK_VERSIONpins, no stale active9.4.0/9.3.xreferences (except allowed history), and that Fleet package policy JSON uses resolved semver variables rather thanlatest.Testing
python -m compileall -q src testswhich completed with only aSyntaxWarningfrom an existingreturnin afinally(non-fatal).pytest tests/test_poc_pipeline.py -qand all tests passed (10 passed).bash -non demo scripts (scripts/demo_up.sh scripts/demo_run.sh scripts/demo_verify.sh scripts/demo_reset.sh scripts/verify_poc.sh) with no syntax errors.docker-compose.poc.ymlanddocker-compose.ymlwithyaml.safe_load()and randocker compose ... config(render) could not be executed because Docker is not available in this environment.docker manifest inspectfor the three9.4.2images and an HTTP manifest probe, but both could not be completed here due to missingdockerbinary and outbound network/Tunnel restrictions, so those checks are documented indocs/poc-setup.mdfor local verification by users.Codex Task