hissqlite-util: print -d tokens as @hex@ like other INN tools

[kev009]

-d used bare hex; switch to the usual @...@ form and use hex() instead of stripping quote()'s X'...' output.

[Julien-Elie]

Thanks for the change.

[Julien-Elie]

Playing a bit with hissqlite-util, remembered entries are shown with @@.
Also, shouldn't default values for $posted and $expires be 0, as other entries without these values set are dumped as 0?

I would suggest that change, if that's OK for you:

--- a/history/hissqlite/hissqlite-util.in
+++ b/history/hissqlite/hissqlite-util.in
@@ -144,8 +144,8 @@ sub count_entries {
 sub dump_history {
     my $statement;
 
-    # hex() renders a BLOB as uppercase hex, or NULL for a remembered entry's
-    # missing token.
+    # hex() renders a BLOB as uppercase hex, or an empty string for a
+    # remembered entry's missing token.
     $statement = $dbh->prepare(
         q{
             select hex(hash), arrived, posted, expires, hex(token)
@@ -156,9 +156,9 @@ sub dump_history {
 
     while (my @row = $statement->fetchrow_array()) {
         my ($hash, $arrived, $posted, $expires, $token) = @row;
-        $posted = defined($posted) ? $posted : '-';
-        $expires = defined($expires) ? $expires : '-';
-        if (!defined($token)) {
+        $posted = defined($posted) ? $posted : '0';
+        $expires = defined($expires) ? $expires : '0';
+        if (!defined($token) || $token eq '') {
             $token = 'remembered';
         } else {
             # The token column stores the raw storage API token, so its hex

I'm also wondering whether it shouldn't be interesting to order the dump by arrival time so as to have a consistent output? select hex(hash), arrived, posted, expires, hex(token) from hist order by arrived;
It will be a little bit slower to answer though.
Or an -o parameter to specify the order if needed, without any sorting by default? -o arrived, -o posted, -o expires
Any thoughts about that?

[kev009]

@Julien-Elie your @@ fix and 0 fix sounds right. I'd lean toward the args/flags as better route (maybe -O to differentiate from ovsqlite-util -o?), because it will require a more expensive DB sort.