hissqlite: batch writes during a HIS_INCORE bulk rebuild#352
Closed
kev009 wants to merge 1 commit into
Closed
Conversation
Reuse HIS_INCORE, which makehistory passes and which hisv6 used for sole writer rebuilds. hissqlite's writes autocommit (one implicit transaction per HISwrite) innd and the in-place expire interleave on the WAL write lock without starving each other using this contract. That per-transaction cost dominates bulk loading though: makehistory rebuilds 2-3x faster in my benchmarking with this similar to hissqlite-convert which also uses similar batch logic and reasoning.
Julien-Elie
added
enhancement
Contributor
|
A useful enhancement. Thanks for it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reuse HIS_INCORE, which makehistory passes and which hisv6 used for sole writer rebuilds.
hissqlite's writes autocommit (one implicit transaction per HISwrite where nnd and the in-place expire interleave on the WAL write lock without starving each other using this contract).
That per-transaction cost dominates bulk loading though: makehistory rebuilds 2-3x faster in my benchmarking with this similar to hissqlite-convert which also uses similar batch logic and reasoning.