Increase test coverage in dpnp.nextafter for signed zeros#2955
Merged
Conversation
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
Collaborator
|
coverage: 78.092%. remained the same — add-test-to-nextafter into master |
Contributor
|
Array API standard conformance tests for dpnp=0.21.0dev1=py313h509198e_11 ran successfully. |
antonwolfy
requested review from
ndgrigorian and
vlad-perevezentsev
as code owners
vlad-perevezentsev
approved these changes
Jun 18, 2026
vlad-perevezentsev
left a comment
vlad-perevezentsev
left a comment
Contributor
There was a problem hiding this comment.
LGTM
Thank you @antonwolfy
github-actions Bot
added a commit
that referenced
this pull request
Jun 18, 2026
This PR adds a test verifying that `dpnp.nextafter` returns the correctly signed zero when stepping between `+0.0` and `-0.0`. It mirrors the regression test added with NumPy 2.5, which fixed `nextafter` returning the wrong-signed zero for the equal-zero case where the destination's sign must determine the sign of the resulting zero. 188c1ce
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a test verifying that
dpnp.nextafterreturns the correctly signed zero when stepping between+0.0and-0.0.It mirrors the regression test added with NumPy 2.5, which fixed
nextafterreturning the wrong-signed zero for the equal-zero case where the destination's sign must determine the sign of the resulting zero.