refactor(memory): use typing.Protocol for MemoryBackend interface#19
Merged
Conversation
- Replace duck-typing hasattr checks with structural Protocol - MemoryBackend is runtime_checkable for isinstance validation - Aligns with hawk-eco architecture: SDKs use structural interfaces
…ckend detection - Import Sequence under TYPE_CHECKING to satisfy ruff UP035/TC003 - Use hasattr instead of isinstance(Protocol) for backend detection since runtime_checkable checks class attrs, not instance attrs, breaking MagicMock-based tests on Python 3.12+
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hasattrchecks withtyping.Protocolstructural interfaceMemoryBackendis@runtime_checkableforisinstancevalidationremember/recallmethods satisfying the Protocol is acceptedArchitecture compliance
Aligns with hawk-eco principle: Python SDKs use structural interfaces (Protocol), not concrete imports from engines.