[ENHANCEMENT] Stop strumline hold splash on Bot Play / Opponent, Allow character metadata to control icon "bop"#6832
Closed
pahaze wants to merge 0 commit into
Closed
[ENHANCEMENT] Stop strumline hold splash on Bot Play / Opponent, Allow character metadata to control icon "bop"#6832pahaze wants to merge 0 commit into
pahaze wants to merge 0 commit into
Conversation
3829dcb to
5805c31
Compare
Contributor
|
This PR has merge conflicts! Please fix them so it can be tested properly. |
Author
Apologies on that, pulled from develop and caused that earlier on, fixed it and opened a new PR with an actual branch dedicated to this change lol |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I noticed a few things that I thought would be nice to be enhanced, namely disabling the opponent's strumline (and, your strumline during Bot Play) hold note splash, and allowing character metadata to control the ability to have their icon bop or not.
The former is something I just had a pet peeve with since it doesn't play the final splash after the hold notes are finished. The latter is something I personally saw fit to be fixed as I was playing around with porting some older mods, and having the ability to use animated icons OOTB now is incredibly nice, but the bop missing just felt wrong.
Screenshots/Videos
Opponent strumline not showing hold note splash
2026-01-28.01-37-42.mp4
Bot Play strumline not showing hold splash
2026-01-28.01-38-44.mp4
Set Health Icon event showing "Bop Enabled" option
2026-01-28.01-40-56.mp4
Sidenote
There's also an absolutely tiny change in the FunkinMemory that I just thought looked nicer. It just changes how the combo numbers are loaded to a for loop rather than doing 1, 2, 3, etc etc manually.
Also sorry about my horrid commit from a few years back, I was 14 and barely knew anything about coding, let alone the idea of animated sprites lol