Skip to content

[ENHANCEMENT] Stop strumline hold splash on Bot Play / Opponent, Allow character metadata to control icon "bop"#6832

Closed
pahaze wants to merge 0 commit into
FunkinCrew:developfrom
pahaze:develop
Closed

[ENHANCEMENT] Stop strumline hold splash on Bot Play / Opponent, Allow character metadata to control icon "bop"#6832
pahaze wants to merge 0 commit into
FunkinCrew:developfrom
pahaze:develop

Conversation

@pahaze

@pahaze pahaze commented Jan 28, 2026

Copy link
Copy Markdown

Description

I noticed a few things that I thought would be nice to be enhanced, namely disabling the opponent's strumline (and, your strumline during Bot Play) hold note splash, and allowing character metadata to control the ability to have their icon bop or not.

The former is something I just had a pet peeve with since it doesn't play the final splash after the hold notes are finished. The latter is something I personally saw fit to be fixed as I was playing around with porting some older mods, and having the ability to use animated icons OOTB now is incredibly nice, but the bop missing just felt wrong.

Screenshots/Videos

Opponent strumline not showing hold note splash

2026-01-28.01-37-42.mp4

Bot Play strumline not showing hold splash

2026-01-28.01-38-44.mp4

Set Health Icon event showing "Bop Enabled" option

2026-01-28.01-40-56.mp4

Sidenote

There's also an absolutely tiny change in the FunkinMemory that I just thought looked nicer. It just changes how the combo numbers are loaded to a for loop rather than doing 1, 2, 3, etc etc manually.
Also sorry about my horrid commit from a few years back, I was 14 and barely knew anything about coding, let alone the idea of animated sprites lol

@github-actions github-actions Bot added status: pending triage Awaiting review. size: medium A medium pull request with 100 or fewer changes. pr: haxe PR modifies game code. labels Jan 28, 2026
@Hundrec Hundrec added type: enhancement Involves an enhancement or new feature. topic: polish Involves minor polish to the UI or gameplay. labels Jan 29, 2026
@Hundrec Hundrec force-pushed the develop branch 2 times, most recently from 3829dcb to 5805c31 Compare February 1, 2026 03:24
@TechnikTil

Copy link
Copy Markdown
Contributor

This PR has merge conflicts! Please fix them so it can be tested properly.

@NotHyper-474 NotHyper-474 added status: needs revision Cannot be approved because it is awaiting some work by the contributor. and removed status: pending triage Awaiting review. labels May 20, 2026
@pahaze pahaze closed this Jun 13, 2026
@github-actions github-actions Bot added size: tiny A tiny pull request with 4 or fewer changes. and removed size: medium A medium pull request with 100 or fewer changes. labels Jun 13, 2026
@pahaze

pahaze commented Jun 13, 2026

Copy link
Copy Markdown
Author

This PR has merge conflicts! Please fix them so it can be tested properly.

Apologies on that, pulled from develop and caused that earlier on, fixed it and opened a new PR with an actual branch dedicated to this change lol

#7689

@NotHyper-474 NotHyper-474 added status: duplicate Issue or PR is redundant to another. and removed type: enhancement Involves an enhancement or new feature. topic: polish Involves minor polish to the UI or gameplay. status: needs revision Cannot be approved because it is awaiting some work by the contributor. pr: haxe PR modifies game code. labels Jun 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: tiny A tiny pull request with 4 or fewer changes. status: duplicate Issue or PR is redundant to another.

Development

Successfully merging this pull request may close these issues.

4 participants