Decouple policy condition API from JDO models#6394
Conversation
Tackles the technical debt of JDO models being reused for REST DTOs for all endpoints under `/v1/policy/{uuid}/condition`.
Also makes the generated OpenAPI spec more reliable b/c it no longer advertises fields that are never used / never returned.
Note that the existing tests already asserted full JSON responses, so no new regression tests were necessary.
Signed-off-by: nscuro <nscuro@protonmail.com>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 8 |
🟢 Coverage 93.33% diff coverage
Metric Results Coverage variation Report missing for 2b4980e1 Diff coverage ✅ 93.33% diff coverage (70.00%) Coverage variation details
Coverable lines Covered lines Coverage Common ancestor commit (2b4980e) Report Missing Report Missing Report Missing Head commit (bf14038) 41730 36107 86.53% Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch:
<coverage of head commit> - <coverage of common ancestor commit>Diff coverage details
Coverable lines Covered lines Diff coverage Pull request (#6394) 60 56 93.33% Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified:
<covered lines added or modified>/<coverable lines added or modified> * 100%1 Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
2 participants
Description
Tackles the technical debt of JDO models being reused for REST DTOs for all endpoints under
/v1/policy/{uuid}/condition.Also makes the generated OpenAPI spec more reliable b/c it no longer advertises fields that are never used / never returned.
Note that the existing tests already asserted full JSON responses, so no new regression tests were necessary.
Addressed Issue
N/A
Additional Details
N/A
Checklist
This PR fixes a defect, and I have provided tests to verify that the fix is effectiveThis PR implements an enhancement, and I have provided tests to verify that it works as intendedThis PR introduces changes to the database model, and I have updated the migration changelog accordinglyThis PR introduces new or alters existing behavior, and I have updated the documentation accordinglyThis PR is a substantial change (per the ADR criteria), and I have added an ADR underdocs/adr/