Conversation
nmurtagh
force-pushed
the
python3
branch
5 times, most recently
from
f83389b to
115331c
Compare
| self.assertEqual(base64_encoded[-1], '=') | ||
|
|
||
| # actual test | ||
| self.assertNotEqual(jose.b64encode_url(istr), '=') |
There was a problem hiding this comment.
This assertion looks broken
|
Looks good to me |
| ('enc', enc), ('alg', alg)]) | ||
| header = dict( | ||
| list((add_header or {}).items()) + [('enc', enc), ('alg', alg)] | ||
| ) |
There was a problem hiding this comment.
You didn't add this but it looks a bit ugly.
It would look much better this way: header = dict(add_header or {}, enc=enc, alg=alg)
|
Please add a note to |
|
@Newky @yuriikonovaliuk Thanks for the reviews guys - I added a commit with some cleanups, please take a look. I removed |
| @@ -58,9 +66,10 @@ def finalize_package_data(self): | |||
| 'Operating System :: OS Independent', | |||
| 'Programming Language :: Python :: 2 :: Only', | |||
There was a problem hiding this comment.
I guess you can just change it to Programming Language :: Python :: 2.7 and add some more with Python 3.* versions
|
Splendid! Django is dropping support for 2.7 next year and jose was one of the hold outs. |
|
Will this get its merge conflicts resolved and an update pushed to pypi? |
|
Why the maintainer of this project hate Python 3 so much? This should have already been merged into master. |
|
Plz, push to pypi? |
|
Hi @nmurtagh, |
|
is that repository deprecated? it doesnt work with python 3. |
9 participants
Addresses #13