Add Playwright happy-path E2E#51
Merged
Merged
Conversation
9e92c57 to
b38f739
Compare
DavidMeritas
approved these changes
Jun 16, 2026
DavidMeritas
left a comment
There was a problem hiding this comment.
Great work on this, ejones! Really well thought out — the run isolation with per-run DB names, ports, and cache dirs is exactly the kind of thing that saves headaches down the road in CI. The data-testid approach for selectors is solid, the SQL injection guards are a nice touch, and the whole create → vote → results happy path reads cleanly. Love the E2E_KEEP_DB=1 escape hatch for debugging too. Thanks for continuing to level up the test infrastructure — this project is in much better shape because of your contributions. 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rcv_e2edatabase for browser testsdata-testidhooks to the AngularJS templates for stable E2E selectorsVerification
npm run test:e2enpm testnpm run build