Skip to content

[int] Add cleanDirectory utility function for general directory clean-up#8584

Open
sfayer wants to merge 1 commit into
DIRACGrid:integrationfrom
sfayer:tidy_htc_clean
Open

[int] Add cleanDirectory utility function for general directory clean-up#8584
sfayer wants to merge 1 commit into
DIRACGrid:integrationfrom
sfayer:tidy_htc_clean

Conversation

@sfayer

@sfayer sfayer commented Jun 8, 2026

Copy link
Copy Markdown
Member

Hi,

Here is the reworked version of this to create a new cleanDirectory utility function and use it in a few places where it makes sense (including the HTCondorCE cleanup).

Regards,
Simon

BEGINRELEASENOTES
*Core
CHANGE: Add cleanDirectory utility function for general directory clean-up
ENDRELEASENOTES

@sfayer sfayer marked this pull request as ready for review June 8, 2026 21:58
@sfayer sfayer requested review from atsareg and fstagni as code owners June 8, 2026 21:58
Comment thread src/DIRAC/Resources/Computing/HTCondorCEComputingElement.py Outdated
@aldbr

aldbr commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

For my education, what are you trying to solve here exactly?

@sfayer sfayer marked this pull request as draft June 11, 2026 18:42
@sfayer sfayer changed the title [int] Use python native for HTCondorCE cleanup rather than running find [int] Add cleanDirectory utility function for general directory clean-up Jun 11, 2026
@sfayer

sfayer commented Jun 11, 2026

Copy link
Copy Markdown
Member Author

Here is my draft for this: We're testing it on one of our test servers before I'll mark it for review. Please feel free to have a quick look and let me know if it needs any major changes before we finish testing it!

It didn't make sense for the TransformationAgent.cleanOldTransformationCache case: This would need an extra filter (to check for files that are still being used) and the whole thing would be much more complicated that the existing code.

Regards,
Simon

@sfayer sfayer force-pushed the tidy_htc_clean branch 5 times, most recently from 8ec8390 to 7bae4cb Compare June 11, 2026 19:57
@sfayer sfayer marked this pull request as ready for review June 15, 2026 09:22
@sfayer

sfayer commented Jun 15, 2026

Copy link
Copy Markdown
Member Author

We've done some tests of this, particularly the securityLog seems fine. It didn't cause any issue for our HTCondorCE submission either, but we use the remote schedd mode, so I'm not sure it's actually activated there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants