based refactors: Improve init/cleanup and split Corosync-related functions into new file

daemons/attrd/attrd_corosync.c

@@ -487,6 +487,12 @@ broadcast_unseen_local_values(void)
     }
 }
 
+/*!
+ * \internal
+ * \brief Initialize \c attrd_cluster and connect to the cluster layer
+ *
+ * \return Standard Pacemaker return code
+ */
 int
 attrd_cluster_connect(void)
 {
@@ -512,11 +518,19 @@ attrd_cluster_connect(void)
     return rc;
 }
 
+/*!
+ * \internal
+ * \brief Disconnect from the cluster layer and free \c attrd_cluster
+ */
 void
 attrd_cluster_disconnect(void)
 {
+    if (attrd_cluster == NULL) {
+        return;
+    }
+
     pcmk_cluster_disconnect(attrd_cluster);
-    pcmk_cluster_free(attrd_cluster);
+    g_clear_pointer(&attrd_cluster, pcmk_cluster_free);
 }
 
 void

daemons/based/Makefile.am

@@ -15,7 +15,9 @@ halibdir	= $(CRM_DAEMON_DIR)
 halib_PROGRAMS	= pacemaker-based
 
 noinst_HEADERS = based_callbacks.h
+noinst_HEADERS += based_corosync.h
 noinst_HEADERS += based_io.h
+noinst_HEADERS += based_ipc.h
 noinst_HEADERS += based_messages.h
 noinst_HEADERS += based_notify.h
 noinst_HEADERS += based_operation.h
@@ -33,6 +35,7 @@ pacemaker_based_LDADD += $(CLUSTERLIBS) $(PAM_LIBS)
 
 pacemaker_based_SOURCES = pacemaker-based.c
 pacemaker_based_SOURCES += based_callbacks.c
+pacemaker_based_SOURCES += based_corosync.c
 pacemaker_based_SOURCES += based_io.c
 pacemaker_based_SOURCES += based_ipc.c
 pacemaker_based_SOURCES += based_messages.c