Fix nav issues#257
Open
Blargian wants to merge 13 commits into
Open
Conversation
- Language picker icon: S3 URL had no CORS headers so CSS mask-image was blocked. Inline the SVG as a base64 data URL — no external request, no CORS needed, works everywhere. - Quickstart back-link 404: Mintlify autogenerates the 'All quickstarts' anchor with a raw /get-started/... path (no /docs basePath). Clicking it navigated to the wrong URL in production. Fix the clone's href and add a click handler with the correct basePath-aware destination. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
…irects
Issue 1 - integrations-fallback.json 404:
The fetch used /assets/integrations-fallback.json (absolute path), which
resolves to clickhouse.com/assets/... instead of clickhouse.com/docs/assets/...
in production. Prepend the /docs basePath when on the subpath deployment.
Issue 2 - RSC prefetch 404s from stale docsLinks:
The fallback JSON contained old Docusaurus-era URLs for 14 integrations
(interfaces/cpp, integrations/kafka, integrations/s3, etc.) that no longer
exist at those paths. Updated to current Mintlify file-path URLs.
Also added 9 redirects for the same old paths so live CMS data (which
we cannot update from this repo) also resolves correctly:
/interfaces/{cpp,csharp,go,javascript,python} → language-clients/
/integrations/kafka → connectors/data-ingestion/kafka
/integrations/kafka/cloud/amazon-msk → .../kafka/msk
/integrations/s3 → .../aws/integrating-s3-with-clickhouse
/integrations/clickpipes/kafka/create-your-first-... → create-kafka-clickpipe
Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
Preview deployment for your docs. Learn more about Mintlify Previews.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
…Explorer All three components used /images/... absolute paths which resolve to clickhouse.com/images/... instead of clickhouse.com/docs/images/... in production. Added assetBase/withBase pattern to each component and applied to all img src and backgroundImage references. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
| { | ||
| "source": "/integrations/clickpipes/kafka/create-your-first-kafka-clickpipe", | ||
| "destination": "/integrations/clickpipes/kafka/create-kafka-clickpipe" | ||
| }, |
There was a problem hiding this comment.
Kafka guide redirect wrong slug
High Severity
The new redirect sends /integrations/clickpipes/kafka/create-your-first-kafka-clickpipe to /integrations/clickpipes/kafka/create-kafka-clickpipe, but the guide’s published slug is still create-your-first-kafka-clickpipe. Bookmarks and fallback links targeting the shorter path may not resolve to the guide.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 497538d. Configure here.
Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
- Remove inner image scale transform (was causing blur artifact during tile hover animation) - Add pointer-events: none to images so Mintlify's click-to-zoom handler doesn't fire and clicks pass through to the tile/link Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Hide navbar until both logo (homepage) and CTA have been injected, then reveal with a short opacity transition to eliminate layout shifts. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
- quickstart-back-link.js: include locale segment in dest URL so translated quickstart pages link back to the correct locale home; fix idempotency check to compare against the rewritten dest href instead of the source anchor's original href (prevents clone being removed/recreated on every MutationObserver pass) - integrations-fallback.json: fix 5 ClickPipes object-storage entries pointing to non-existent /object-storage/overview; use /object-storage/amazon-s3/overview which actually exists - redirects.json + fallback JSON: fix /integrations/s3 redirect target casing from lowercase aws/ to AWS/ to match the actual directory Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
There are 3 total unresolved issues (including 2 from previous reviews).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 5358d5a. Configure here.
| "category": "CLICKPIPES", | ||
| "supportLevel": "CORE", | ||
| "docsLink": "https://clickhouse.com/docs/integrations/clickpipes/object-storage", | ||
| "docsLink": "https://clickhouse.com/docs/integrations/clickpipes/object-storage/amazon-s3/overview", |
There was a problem hiding this comment.
Wrong ClickPipes docs URLs
Medium Severity
Several integration fallback entries for non–Amazon S3 ClickPipes (Google Cloud Storage, Azure Event Hubs, Azure Blob Storage, DigitalOcean Spaces) now share the Amazon S3 object-storage overview docsLink, so the integrations grid sends users to the wrong documentation.
Additional Locations (3)
Reviewed by Cursor Bugbot for commit 5358d5a. Configure here.
The original files were named with the wrong light/dark suffix. Renaming the actual files and reverting the code swap keeps the naming convention consistent with all other dataset images. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
- GCS: use google-cloud-storage/overview (dedicated page exists) - Azure Blob: use azure-blob-storage/overview (dedicated page exists) - DigitalOcean Spaces: revert to generic /object-storage (no dedicated page) - Azure Event Hubs: revert to generic /object-storage (CMS categorisation issue) - Amazon S3: unchanged Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.