Skip to content

Bump npm dep & rewrote deprecated sass#61

Open
louisgcom wants to merge 1 commit into
Beg-in:masterfrom
louisgcom:master
Open

Bump npm dep & rewrote deprecated sass#61
louisgcom wants to merge 1 commit into
Beg-in:masterfrom
louisgcom:master

Conversation

@louisgcom

Copy link
Copy Markdown

No description provided.

@BrainBacon

Copy link
Copy Markdown

Why did you change the hex color codes to rgb instead?

@louisgcom

Copy link
Copy Markdown
Author

I didn't change hex color codes to rgb.
I updated darken and other sass color functions to color.adjust.
color.adjust is more precise, it does not round results.
Since results is a decimal and do not fall exactly on a hexadecimal color, it decides to keep the values ​​in rgb.

@BrainBacon

Copy link
Copy Markdown

Makes sense 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants