Skip to content

fix(constraints): vector cleanup#1401

Open
Dhruv-0-Arora wants to merge 2 commits into
devfrom
darora1/fix/vector-cleanup
Open

fix(constraints): vector cleanup#1401
Dhruv-0-Arora wants to merge 2 commits into
devfrom
darora1/fix/vector-cleanup

Conversation

@Dhruv-0-Arora

@Dhruv-0-Arora Dhruv-0-Arora commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

SYNTH-259

Replacing the JoltRVec3 with a JoltVec3 in the createAnchorPoint() function
Adding type annotations to ConstraintSettingsUtililties

Note

This PR conflicts with #1418

@Dhruv-0-Arora Dhruv-0-Arora self-assigned this Jul 9, 2026
@Dhruv-0-Arora
Dhruv-0-Arora requested review from a team as code owners July 9, 2026 22:43
@Dhruv-0-Arora
Dhruv-0-Arora requested review from 0xda157 and RoushilS July 9, 2026 22:43
@Dhruv-0-Arora Dhruv-0-Arora added the physics Relating to either the underlying physics engine or the usage of it label Jul 9, 2026
Comment thread fission/src/systems/physics/PhysicsSystem.ts Outdated
Comment thread fission/src/systems/physics/PhysicsSystem.ts Outdated
Comment thread fission/src/systems/physics/PhysicsSystem.ts Outdated
Comment thread fission/src/systems/physics/ConstraintSettingsUtilities.ts
@azaleacolburn

Copy link
Copy Markdown
Contributor

In the future, be sure to follow the Synthesis PR template and crosslink with a Jira ticket.

@Dhruv-0-Arora

Copy link
Copy Markdown
Collaborator Author

There was no JIRA ticket for this. It was a fix

Dhruv-0-Arora and others added 2 commits July 15, 2026 14:21
Signed-off-by: Dhruv Arora <a_dhruv@outlook.com>
Signed-off-by: Dhruv Arora <dhruv.arora1@autodesk.com>

Co-authored-by: Azalea Colburn <azalea.colburn@autodesk.com>
@Dhruv-0-Arora
Dhruv-0-Arora force-pushed the darora1/fix/vector-cleanup branch from dae9de7 to 93067f8 Compare July 15, 2026 21:29
@azaleacolburn

Copy link
Copy Markdown
Contributor

You should still make a jira ticket, just label it as a bug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

physics Relating to either the underlying physics engine or the usage of it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants