Fix sanitizer test failures#103
Open
CarlosFelipeOR wants to merge 11 commits into
Open
Conversation
- Increase server startup timeouts for sanitizer builds - Increase job timeouts from 180 to 300 minutes - Add xfails for known bugs exposed by sanitizers - Skip benchmark tests with sanitizers (too slow) Co-authored-by: Cursor <cursoragent@cursor.com>
- aggregate_functions: increase receive_timeout/send_timeout to 900s for sanitizers - rbac: skip compiled expression cache tests (JIT disabled in sanitizers) Co-authored-by: Cursor <cursoragent@cursor.com>
- base_58: change Fail to Error (test has UnboundLocalError) - rbac: fix FFails format (tuple not list), combine ARM + sanitizer check - iceberg: skip iceberg engine tests with sanitizers (server unstable) Co-authored-by: Cursor <cursoragent@cursor.com>
MSAN builds are 10-20x slower and need more time for server startup. Co-authored-by: Cursor <cursoragent@cursor.com>
…ge conflict residue Signed-off-by: CarlosFelipeOR <carlosfelipeor@gmail.com>
Signed-off-by: CarlosFelipeOR <carlosfelipeor@gmail.com>
Signed-off-by: CarlosFelipeOR <carlosfelipeor@gmail.com>
… ccx33 Signed-off-by: CarlosFelipeOR <carlosfelipeor@gmail.com>
…me/s3 timeouts; revert OOM suites to cpx62 Signed-off-by: CarlosFelipeOR <carlosfelipeor@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses test failures in UBSAN, ASAN, TSAN, and MSAN regression runs for the 26.3 release. Combines real upstream-bug xfails with infrastructure tuning (runner sizes, timeouts) for sanitizer overhead.
Real upstream bugs (xfailed under sanitizers, not backported to stable-26.3)
iceberg/iceberg table engine/feature/row policies/*Logical error: 'prewhere_info'chassert in sanitizer/debug builds (Fail + Error)iceberg/iceberg engine/*/schema evolution/*kerberos/*(MSAN only)bufferToStringstrips trailing NUL bytes from opaque AP-REP tokens; krb5 ASN.1 decoder reads 1 byte of uninitialized memory → MSAN aborts every requestTest framework / FP-rounding xfails
aggregate_functions/part 3/state/rankCorrState/with group by(TSAN only)_binarybuild; routes to the existing_binarysnapshot variantbase_58/memory usage/*alter/attach partition/*,alter/replace partition/*BAD_ARGUMENTSon cross-disk replaceSanitizer timeout / runner adjustments (infrastructure)
helpers/cluster.pywait_clickhouse_healthy90→300s,start_clickhouse60→300s,restart_clickhouseincreased — sanitizer startup is 3–4× slowerhelpers/common.pycheck_with_any_sanitizer/ per-sanitizer helpers (were always returning False)aggregate_functions/regression.py,parquet/regression.pywait_for_async_insert_timeout/receive_timeout/send_timeoutto 900s under sanitizer (default 120s too tight for heavy INSERTs)ontime_benchmark/tests/benchmark.pynode.querybash timeout 1200→3600s andreceive_timeout600→1800s under sanitizer (CSV.gz ingest under MSAN)s3/tests/common.pyadd_configauto-bumps reload timeout 60→300s under sanitizer; fixremote_host_filter_configto forwardtimeout.github/workflows/run-regression-high-performance.ymlcpx62(32 GB RAM); increasetimeout_minutesto 360 for 6 long-running suites (alter_replace_partition, aggregate_functions_1/3, ldap_role_mapping, memory, tiered_storage_gcs)Notes
ontime_benchmarkis not skipped under sanitizers (passes on all sanitizers once the bash timeout is large enough).wait_for_async_insert_timeoutincreases resolved earlier sanitizer flakes inaggregate_functionsandparquet(not flagged in upstream-bug section because no client-visible bug remains).Test plan