fix(agentic_rag): honor similarity_threshold in deduplicate_chunks#829
Open
andrewwhitecdw wants to merge 2 commits into
Open
fix(agentic_rag): honor similarity_threshold in deduplicate_chunks#829andrewwhitecdw wants to merge 2 commits into
andrewwhitecdw wants to merge 2 commits into
Conversation
The deduplicate_chunks helper accepted a similarity_threshold parameter but only performed exact-match deduplication. Use Jaccard similarity over normalized token sets so the threshold is actually honored. Signed-off-by: Andrew White <andrew.white@cdw.com> Signed-off-by: Andrew White <andrewh@cdw.com>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug:
deduplicate_chunksaccepted asimilarity_thresholdargument but only performed exact-match deduplication, so the threshold was silently ignored.Fix: Compare chunks using Jaccard similarity over normalized token sets and only keep a chunk when it is below the threshold relative to every chunk already kept.
Test: Added regression tests covering exact duplicates, near-duplicates at the default threshold, threshold sensitivity, and empty input.