fix(go): resolver writability, truthful push reporting, existing-branch builds, test-before-push#118
Open
AbirAbbas wants to merge 4 commits into
Open
fix(go): resolver writability, truthful push reporting, existing-branch builds, test-before-push#118AbirAbbas wants to merge 4 commits into
AbirAbbas wants to merge 4 commits into
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
AbirAbbas
force-pushed
the
fix/agent-reliability
branch
from
July 24, 2026 19:58
e040e53 to
d88c69a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Four operational fixes for the Go port, all discovered while running SWE-AF against real PRs on 2026-07-24:
resolvenow defaults its fixer role topermission_mode: "auto". The empty default landed the pr_resolver agent in a read-only sandbox: it validated findings but could not edit files, so every default resolve run reported "valid finding, but the read-only workspace prevents applying the fix" and changed nothing (observed on 7 consecutive runs). An explicitconfig.permission_modeis still honored verbatim.resolveverifies push state via git instead of trusting the agent's self-report. The remote head of the target branch is captured before the role runs and re-resolved after; if it advanced, the result reportspushed: truewith real commit SHAs and changed files even when the agent's final JSON fails schema validation. Live impact: on 4 of 7 runs the fix was committed and pushed while the result claimedpushed: false/ total failure.buildgains an optionalwork_branchinput. When set, git-init fetches and checks out that existing branch as the integration branch (no new branch), and fails fast — before any planning/coder spend — if the branch does not exist on the remote. Previously a goal targeting an existing PR branch was silently executed againstmain, burning a full pipeline run to produce 0/N completed issues (observed twice).Provenance
Implemented by SWE-AF itself (build pipeline), then salvaged by cherry-picking the three fix commits off the run's integration branch — the run's finalize stage had committed a destructive tree pruning (−63.9k lines), which is why the pipeline never opened this PR on its own. Prompt goldens aligned in a follow-up commit.
Test plan
go build ./...cleango test ./...— 27/27 packages passgofmt -lclean🤖 Generated with Claude Code