Fix roundtrip checkpoint conversion test#4609
Open
hengtaoguo wants to merge 1 commit into
Open
Conversation
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
hengtaoguo
force-pushed
the
hengtaoguo-fix
branch
from
July 24, 2026 23:51
c484a01 to
eabc6de
Compare
hengtaoguo
marked this pull request as ready for review
July 25, 2026 00:08
hengtaoguo
requested review from
RissyRan,
jiangjy1982,
parambole,
shuningjin and
suexu1025
as code owners
July 25, 2026 00:08
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
hengtaoguo
requested review from
NuojCheng,
aireenmei,
bvandermoon,
gagika,
gobbleturk,
huytransformer,
igorts-git,
richjames0,
shralex and
xibinliu
as code owners
July 25, 2026 00:08
NuojCheng
approved these changes
Jul 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The qwen3-30b-a3b roundtrip checkpoint conversion test was failing in CI (logs). There were two underlying causes:
Unknown flag save_dtype: This latent argument-isolation bug was recently exposed by the JAX 0.10.2 dependency upgrade, which changed when the Abseil-backed configuration was initialized.
--save_dtypewas parsed by the converter's localargparseparser but remained in the globalsys.argv. When JAX initialized Abseil, Abseil attempted to parse the same argument and raisedUnrecognizedFlagErrorbecausesave_dtypeis not an Abseil flag. This change replacessys.argvwith the remaining MaxText arguments before JAX initialization.NotImplementedError on cpu: For
flashorautoselectedattention kernels,AttentionOpassumed GPU hardware when the platform was not TPU. It did not check if the active platform was actually CPU, leading to it attempting to call the GPU-onlyPallasTritonFlashAttentionand throwing aNotImplementedErroron CPU. We fixed this by adding an explicit check fortarget_hardware == "cpu"to fallback to standard dot-product attention (apply_attention_dot).attention=dot_productto avoid crashes. With this patch, AttentionOp now automatically handles this fallback, allowing the conversion to run smoothly on CPU using default configurations..Tests
Covered in CI (logs).
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.