Skip to content

Doc: Add note about AutoCRLF issue#268

Open
maxisam wants to merge 4 commits into
AGWA:masterfrom
maxisam:patch-1
Open

Doc: Add note about AutoCRLF issue#268
maxisam wants to merge 4 commits into
AGWA:masterfrom
maxisam:patch-1

Conversation

@maxisam

@maxisam maxisam commented Dec 22, 2022

Copy link
Copy Markdown

@alerque

alerque commented Dec 22, 2022

Copy link
Copy Markdown
Contributor

If this is a necessary configuration on Windows shouldn't git-crypt itself be adding it the attributes?

@maxisam

maxisam commented Dec 22, 2022

Copy link
Copy Markdown
Author

I think it is because autocrlf is default/recommend to auto in Windows. I believe it might work just fine with autocrlf=false.
I don't write c++ for 20 years, so I will not mess around the code. But I think this deserves a note in the Readme, since it caused me couple hours to figure this out.

@alerque

alerque commented Dec 22, 2022

Copy link
Copy Markdown
Contributor

Yes I understand how that setting would cause unexpected line endings, the surprising bit to me is that this hasn't been bumped into before by other Windows users since that's kind of the default (if not so much de facto) usage.

@maxisam

maxisam commented Dec 22, 2022

Copy link
Copy Markdown
Author

Yeah, that makes two of us. But I don't use autocrl = true until 2 years ago. And this project doesn't have windows build until 0.7.0. So I guess not so many windows users here.

Comment thread README.md Outdated
@maxisam maxisam changed the title Update Readme with workaround for Windows Doc: Add note about AutoCRLF issue Dec 22, 2022
@AGWA AGWA added this to the 0.9.0 milestone Sep 24, 2025
@AGWA AGWA added the windows Issue only affects Windows label Sep 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

windows Issue only affects Windows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants