Follow WP Coding Standards#1115
Open
dkotter wants to merge 3 commits into
Open
Conversation
…al fixes or ignoring things that aren't problems
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
Up to this point we've been using the
10up-Defaultcoding standards, which utilizes the WP Coding Standards but also adds it's own rules on top. We recently started to migrate our plugins to just using the WP Coding Standards as that seems like a better standard to follow so this PR does that for ClassifAI.This removes the use of
10up/phpcs-composerand replaces that withautomattic/vipwpcsandwp-coding-standards/wpcs. We also update our PHPCS config to ensure we're utilizing this.I then ran the PHPCS autofixer to fix all easy issues (like using
arrayinstead of[]) and then I manually went through and addressed all remaining errors and warnings, either directly fixing those if needed or adding ignore statements for things that didn't need fixed.How to test the Change
Ensure all checks pass on this PR, most importantly the PHPCS one. If desired, do a general smoke testing of the plugin.
Changelog Entry
Credits
Props @dkotter
Checklist: