Increase PHPStan level to 5 and fix all reported errors#1114
Merged
Conversation
4 tasks
jeffpaul
approved these changes
Jun 15, 2026
jeffpaul
left a comment
jeffpaul
left a comment
Member
There was a problem hiding this comment.
Thanks for all these, feel free to go ahead and merge all the way down
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
Note
This is branched from #1113 to try and keep PRs as small as possible.
This PR updates our PHPStan config to level 5 and fixes all newly flagged errors.
How to test the Change
Mainly just ensuring all tests pass on this PR. If desired, can do smoke testing across the entire plugin
Changelog Entry
Credits
Props @dkotter
Checklist: