Skip to content

Add CI for PDF generation#90

Merged
0xAX merged 1 commit into
0xAX:masterfrom
rcalixte:mk_pdf
Jul 16, 2026
Merged

Add CI for PDF generation#90
0xAX merged 1 commit into
0xAX:masterfrom
rcalixte:mk_pdf

Conversation

@rcalixte

@rcalixte rcalixte commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Description

Add CI to automatically generate PDFs on pushes to master with a manual trigger for creation as well.

A CI job sample run is here the forked repository contains a release asset with the PDF as well.

Changes proposed in this pull request:

Content modifications are to support PDF generation:

  • SVGs were converted to PNGs
  • One newline inserted

Related issues

@rcalixte
rcalixte requested review from 0xAX and klaudiagrz as code owners July 6, 2026 19:57
@0xAX

0xAX commented Jul 6, 2026

Copy link
Copy Markdown
Owner

@rcalixte thank you very much! I will take a look tomorrow morning

@0xAX

0xAX commented Jul 7, 2026

Copy link
Copy Markdown
Owner

@rcalixte I tested it and it looks really great! Thank you a lot. I have just two little suggestions that I'll describe in the next comments.

Comment thread .github/workflows/gen-pdf.yaml Outdated
Comment thread scripts/pdf/include.tex
@rcalixte
rcalixte force-pushed the mk_pdf branch 3 times, most recently from cc091dc to 9c93155 Compare July 14, 2026 23:16
@0xAX

0xAX commented Jul 15, 2026

Copy link
Copy Markdown
Owner

@rcalixte thank you for the update. In general looks good to me! I will just test it a bit later today/tomorrow and if everything is good lets merge

@0xAX

0xAX commented Jul 15, 2026

Copy link
Copy Markdown
Owner

@rcalixte Only little comment about pandoc.sh, can you please add it and let's merge!

@rcalixte
rcalixte force-pushed the mk_pdf branch 2 times, most recently from 2addd38 to dfba97b Compare July 15, 2026 22:17
@0xAX
0xAX self-requested a review July 16, 2026 09:28
@0xAX

0xAX commented Jul 16, 2026

Copy link
Copy Markdown
Owner

@rcalixte thank you a lot for your contribution! Merging.

@0xAX
0xAX merged commit eb7acae into 0xAX:master Jul 16, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants