Skip to content

Rebrands and reorgs#442

Closed
umar-ahmed wants to merge 10 commits into
security-alliance:developfrom
umar-ahmed:rebrands-and-reorgs
Closed

Rebrands and reorgs#442
umar-ahmed wants to merge 10 commits into
security-alliance:developfrom
umar-ahmed:rebrands-and-reorgs

Conversation

@umar-ahmed

Copy link
Copy Markdown

Frameworks PR Checklist

Thank you for contributing to the Security Frameworks! Before you open a PR, make sure to read information for contributors and take a look at the following checklist:

  • Describe your changes, substitute this text with the information
  • If you are touching an existing piece of content, tag current contributors from the attribution list
  • If there is a steward for that framework, ask the steward to review it
  • If you're modifying the general outline, make sure to update it in the vocs.config.ts adding the dev: true parameter
  • If you need feedback for your content from the wider community, share the PR in our Discord
  • Review changes to ensure there are no typos; see instructions below.

@github-actions

github-actions Bot commented Apr 5, 2026

Copy link
Copy Markdown

Sidebar Configuration Reminder

This PR includes added, renamed, or removed documentation files:

  • docs/pages/governance/rebrands-and-reorgs.mdx (added)

Please ensure that:

  • The sidebar in vocs.config.tsx has been updated to include these files
  • New content has the dev: true parameter so it's marked as under development
  • Sidebar links match the file paths - use the preview deployment to verify

See Contributing Guide – Sidebar & Navigation for more details.


This is an automated reminder. If this PR doesn't need sidebar changes, you can ignore this message.

@mattaereal

Copy link
Copy Markdown
Collaborator

I really like what I'm seeing so far! Thanks for this contribution. I haven't even thought about this specific type of content for frameworks yet, although present in my head

@mattaereal

mattaereal commented Jun 29, 2026

Copy link
Copy Markdown
Collaborator

@umar-ahmed are you satisfied so far with what you have written? Me and @scode2277 thinks it looks good. Could you resolve the merging conflicts?

@mattaereal mattaereal marked this pull request as ready for review June 29, 2026 14:52

@frameworks-volunteer frameworks-volunteer left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Model: z-ai/glm-5.2 Reasoning: medium Provider: openrouter

Review: PR #442 — Rebrands and Reorgs

Security Review

  • No hardcoded secrets, tokens, or API keys found.
  • No injection vectors (XSS, path traversal, etc.) — content is static MDX.
  • No unsafe deserialization or eval.
  • No suspicious dependencies introduced.
  • External links point to legitimate sources (x.com, yahoo finance, malwarebytes, coinspect). All verified returning HTTP 200.
  • No sensitive data exposure in logs or outputs.

Security: PASS

QA Review

Positive:

  • New page rebrands-and-reorgs.mdx follows existing frontmatter structure and conventions.
  • Tags (Operations & Strategy, Community & Marketing) are valid and used in other pages.
  • vocs.config.tsx entry includes dev: true — correct for new pages.
  • Internal links in index.mdx and overview.mdx match the new page slug /governance/rebrands-and-reorgs.
  • fetched-tags.json updated with the new page entry.
  • sectionMappings changes are alphabetical reordering only — no functional changes to mappings.
  • Content is well-structured, covers real-world examples (MakerDAO→Sky, FTX, OpenClaw), and provides actionable guidance.

Issues (non-blocking):

  1. PR body is the unfilled default template — please describe the changes per the checklist. (Expected for a DRAFT, but should be filled before requesting review.)
  2. Contributors frontmatter has reviewed: [] and fact-checked: [] — consider tagging reviewers before merging.
  3. Minor naming inconsistency: index.mdx and vocs.config.tsx use "Rebrands & Reorgs" while the page title is "Rebrands & Reorganizations". Consider aligning the short name across all references.
  4. The overview.mdx entry is numbered 5. — verify the numbering is intentional (the list previously had 4 items, this adds a 5th, which is correct).

Verdict

Content is solid and security-clean. Non-blocking items above should be addressed before merge but don't block draft review. Approving as a draft — please fill in the PR description and align naming before final merge.

@scode2277

Copy link
Copy Markdown
Collaborator

Hey @umar-ahmed, as we migrated from vocs v1 to their v2, and this PR was from before that, i made some updates to the structure of the files you contributed (no content changed, only config).

Tough, to make this fully ready to go, we need you to resolve merging conflicts (or pull from our develop - either will resolve everything).🙏🏻

@umar-ahmed

Copy link
Copy Markdown
Author

Appreciate it thank you!

I haven't had as much time to put towards getting this merged in. So if this is blocking other work, please feel free to close and I can revisit

@mattaereal

Copy link
Copy Markdown
Collaborator

@frameworks-volunteer, can you create another PR based on this one, fixing the conflicts so we can merge it into dev at least? Without literally modifying content, just explaining in the PR via message, explain how you'd fill the potential gaps in the suggested content or structure the content differently, in case it applies; no need to force anything.

@frameworks-volunteer

Copy link
Copy Markdown
Collaborator

Model: z-ai/glm-5.2 Reasoning: medium Provider: openrouter

Opened PR #546 with @umar-ahmed's content rebased onto current develop. All conflicts resolved — original content preserved verbatim, only config files adapted for the vocs v2 migration.

The PR body includes suggestions for potential content gaps and structural improvements (not forced, just observations):

  • Frontmatter title/description format to match repo convention
  • Adding a Key Takeaway block per AGENTS.md guidelines
  • Condensing the "Why is it Important" section (8 subsections)
  • Using a table for the "Keep Old Accounts" practical guidance
  • Adding "Lesson:" lines to each case study
  • Descriptive link text for additional resources
  • Cross-references to related frameworks (risk management, incident response, opsec)
  • Smart contract migration security subsection

#546

@mattaereal mattaereal closed this Jul 6, 2026
mattaereal pushed a commit that referenced this pull request Jul 8, 2026
)

* Add Rebrands & Reorganizations governance page

Rebases PR #442 by umar-ahmed onto current develop, resolving merge
conflicts. Content is preserved as-is; only config files (fetched-tags.json,
vocs.config.ts) were adapted for the vocs v2 migration. Contributor
frontmatter updated to credit mattaereal and scode2277 as reviewers.

Based on #442.

* fix: address review feedback on rebrands-and-reorgs page

- Fix frontmatter title to include "| Security Alliance" suffix
- Expand description to 140+ chars with action verbs
- Add Key Takeaway block after intro per AGENTS.md convention
- Condense "Inherited Reputation" and "DNS" into single subsection
- Transform "Keep Old Accounts" bullet list into scannable table
- Add "Lesson:" line after each case study (MakerDAO, FTX, OpenClaw)
- Replace bare URLs in Additional Resources with descriptive link text
- Add Related Frameworks cross-references section

* chore: add umar-ahmed to contributors.json as original author
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants