Rebrands and reorgs#442
Conversation
Updated the title and description for clarity and relevance.
Sidebar Configuration ReminderThis PR includes added, renamed, or removed documentation files:
Please ensure that:
See Contributing Guide – Sidebar & Navigation for more details. This is an automated reminder. If this PR doesn't need sidebar changes, you can ignore this message. |
|
I really like what I'm seeing so far! Thanks for this contribution. I haven't even thought about this specific type of content for frameworks yet, although present in my head |
|
@umar-ahmed are you satisfied so far with what you have written? Me and @scode2277 thinks it looks good. Could you resolve the merging conflicts? |
frameworks-volunteer
left a comment
There was a problem hiding this comment.
Model: z-ai/glm-5.2 Reasoning: medium Provider: openrouter
Review: PR #442 — Rebrands and Reorgs
Security Review
- No hardcoded secrets, tokens, or API keys found.
- No injection vectors (XSS, path traversal, etc.) — content is static MDX.
- No unsafe deserialization or eval.
- No suspicious dependencies introduced.
- External links point to legitimate sources (x.com, yahoo finance, malwarebytes, coinspect). All verified returning HTTP 200.
- No sensitive data exposure in logs or outputs.
Security: PASS
QA Review
Positive:
- New page
rebrands-and-reorgs.mdxfollows existing frontmatter structure and conventions. - Tags (
Operations & Strategy,Community & Marketing) are valid and used in other pages. vocs.config.tsxentry includesdev: true— correct for new pages.- Internal links in
index.mdxandoverview.mdxmatch the new page slug/governance/rebrands-and-reorgs. fetched-tags.jsonupdated with the new page entry.sectionMappingschanges are alphabetical reordering only — no functional changes to mappings.- Content is well-structured, covers real-world examples (MakerDAO→Sky, FTX, OpenClaw), and provides actionable guidance.
Issues (non-blocking):
- PR body is the unfilled default template — please describe the changes per the checklist. (Expected for a DRAFT, but should be filled before requesting review.)
- Contributors frontmatter has
reviewed: []andfact-checked: []— consider tagging reviewers before merging. - Minor naming inconsistency:
index.mdxandvocs.config.tsxuse "Rebrands & Reorgs" while the page title is "Rebrands & Reorganizations". Consider aligning the short name across all references. - The
overview.mdxentry is numbered5.— verify the numbering is intentional (the list previously had 4 items, this adds a 5th, which is correct).
Verdict
Content is solid and security-clean. Non-blocking items above should be addressed before merge but don't block draft review. Approving as a draft — please fill in the PR description and align naming before final merge.
|
Hey @umar-ahmed, as we migrated from vocs v1 to their v2, and this PR was from before that, i made some updates to the structure of the files you contributed (no content changed, only config). Tough, to make this fully ready to go, we need you to resolve merging conflicts (or pull from our develop - either will resolve everything).🙏🏻 |
|
Appreciate it thank you! I haven't had as much time to put towards getting this merged in. So if this is blocking other work, please feel free to close and I can revisit |
|
@frameworks-volunteer, can you create another PR based on this one, fixing the conflicts so we can merge it into dev at least? Without literally modifying content, just explaining in the PR via message, explain how you'd fill the potential gaps in the suggested content or structure the content differently, in case it applies; no need to force anything. |
|
Model: Opened PR #546 with @umar-ahmed's content rebased onto current develop. All conflicts resolved — original content preserved verbatim, only config files adapted for the vocs v2 migration. The PR body includes suggestions for potential content gaps and structural improvements (not forced, just observations):
|
) * Add Rebrands & Reorganizations governance page Rebases PR #442 by umar-ahmed onto current develop, resolving merge conflicts. Content is preserved as-is; only config files (fetched-tags.json, vocs.config.ts) were adapted for the vocs v2 migration. Contributor frontmatter updated to credit mattaereal and scode2277 as reviewers. Based on #442. * fix: address review feedback on rebrands-and-reorgs page - Fix frontmatter title to include "| Security Alliance" suffix - Expand description to 140+ chars with action verbs - Add Key Takeaway block after intro per AGENTS.md convention - Condense "Inherited Reputation" and "DNS" into single subsection - Transform "Keep Old Accounts" bullet list into scannable table - Add "Lesson:" line after each case study (MakerDAO, FTX, OpenClaw) - Replace bare URLs in Additional Resources with descriptive link text - Add Related Frameworks cross-references section * chore: add umar-ahmed to contributors.json as original author
Frameworks PR Checklist
Thank you for contributing to the Security Frameworks! Before you open a PR, make sure to read information for contributors and take a look at the following checklist:
vocs.config.tsadding thedev: trueparameter