Double quote strings that contain single quotes only (retry)#336
Open
hsbt wants to merge 1 commit into
Open
Conversation
stomar
changed the title
hsbt
force-pushed
the
revert-335-revert-325-fix_324
branch
from
6425a23 to
8a3710a
Compare
There was a problem hiding this comment.
Pull request overview
This PR adjusts Psych’s YAML string emission to prefer double-quoted scalars for strings that contain single-quote characters (but no double quotes), avoiding the YAML single-quote escaping behavior (''). It adds a regression test to lock in the expected output and round-trip loading.
Changes:
- Add a new test asserting that strings containing
'are emitted with double quotes (to avoid escaping). - Update
Psych::Visitors::YAMLTree#visit_Stringto selectNodes::Scalar::DOUBLE_QUOTEDfor strings matching the new “single quotes present, no double quotes” condition.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
test/psych/test_string.rb |
Adds regression coverage for double-quoting strings containing single quotes to avoid escaping. |
lib/psych/visitors/yaml_tree.rb |
Updates string-style selection logic to emit double-quoted scalars for the new case. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+314
to
315
| elsif o.match?(/^[^[:word:]][^"]*$/) || o.match?(/^([^"]*'+[^"]*)+$/) | ||
| style = Nodes::Scalar::DOUBLE_QUOTED |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original pull request: #325
@knugie Your changes was different behavior with bundler behavior: https://github.com/bundler/bundler/blob/master/lib/bundler/yaml_serializer.rb#L8
There is no time to coordinate this specification for Ruby 2.5.0. I try to this next year(Ruby 2.6 and psych 3.1.0)