statApp/Db Makefile

[hanlet]

We perform macro substitution at build time, therefore, we need the statApp/Db/*.template files in the ./linStat/db. Can we add them to the Makefile?

Would you prefer that I do this as a PR, or an issue?

[mdavidsaver]

Can you provide more details? I would like to keep the many substitution and template files as internal details of linStat, so that I can change them as convenient.

[hanlet]

When I use the substitution files to populate (macro substitution) linStatX.db in my IOC xxxApp/Db area, it complains that it cannot find the yyy.template files

[mdavidsaver]

Sorry if I am being dense, but why is it not sufficient for you to use the four installed .db files? These are individually complete database files, which do not reference any .template files.

$ ls db
linStatFS.db  linStatHost.db  linStatNIC.db  linStatProc.db

I guess I do not understand what you mean by "We perform macro substitution at build time ...". Can you provide, or point to, an example?

[hanlet]

My error, I now understand what you are doing.

On another note, is there a reason to use the prefix macro P in some files and IOC in others?

[mdavidsaver]

prefix macro P in some files and IOC in others?

I started with $(IOC) for consistency with devIocStats, then ran into limits. With linStatNIC.db I added a second macro with the interface name. For linStatFS.db this was not practical since / should not be in a record name. In hindsight, perhaps I should have done the same with NIC?

dbLoadRecords("../../db/linStatNIC.db","IOC=$(IOC),NIC=lo")
dbLoadRecords("../../db/linStatNIC.db","IOC=$(IOC),NIC=eth")

dbLoadRecords("../../db/linStatFS.db","P=$(IOC):ROOT,DIR=/")

I hope that I never forget myself and claim that I am consistent with naming :P

[tynanford]

In hindsight, perhaps I should have done the same with NIC?

I was thinking of creating an issue ticket asking this question before seeing this. Some of our NIC names have periods in them which doesn't play well with PV names.

Maybe we could add a P macro for linStatNIC and default the value to $(IOC):NET:$(NIC) for backwards compatibility?

[mdavidsaver]

Maybe we could add a P macro for linStatNIC and default the value to $(IOC):NET:$(NIC) for backwards compatibility?

Changing names seems reasonable if compatibility can be maintained. If not, renaming is still possible although maybe paired with a .db file rename.