Bump external/termux-elf-cleaner from ee5385e to 3da3eea

[dependabot]

Bumps external/termux-elf-cleaner from ee5385e to 3da3eea (~65 commits, pre-1.10 → past 2.2.1).

This bump required accompanying updates to tools/fastdev/elfcleaner/CMakeLists.txt to stay in sync with upstream changes:

• Updated the source path from termux-elf-cleaner.cpp to elf-cleaner.cpp (file renamed upstream).
• Bumped the C++ standard from C++17 to C++20 (the source now uses std::counting_semaphore).
• Added the PACKAGE_NAME, PACKAGE_VERSION, and COPYRIGHT compile definitions now required by the source, with the version extracted into an ELFCLEANER_VERSION variable.

What we gain

Correctness / runtime fixes

• TLS segment alignment fix on API < 29 — ports the well-known align_fix.py patch. Prevents TLS-alignment crashes when running on older Android (and tools like Valgrind).
• DT_GNU_HASH removal extended to API < 23 (was <= 21). It isn't supported on API 22 either, so the previous range left bad entries on API 22 binaries.
• DT_VERNEEDED typo → DT_VERNEED when refreshing elf.h from glibc; aligns the cleaner with the actual ELF spec name.
• AArch64 entries from NDK 23 are now recognized/handled.
• --dry-run no longer modifies the binary (it actually did before — straight-up bug).
• Proper file-handle cleanup on error paths (no leaked fds on failure).
• EI_CLASS-related errors now go to stderr instead of being swallowed.

Performance

• Multithreaded cleaning using std::counting_semaphore (this is why the C++20 bump is needed). Faster across many native libs in an app build.

Usability / build-system

• New runtime flags: --api-level NN, --quiet, --dry-run, --version, plus getopt-based arg parsing (order no longer matters).
• Upstream switched from autotools → CMake, which is why our tools/fastdev/elfcleaner/CMakeLists.txt is updated.
• Upstream now ships a real test suite (curl + Valgrind fixture binaries) — not consumed by us, but reduces regression risk in future bumps.

The headline items for shipping apps are the TLS alignment fix and the DT_GNU_HASH API-22 fix; the rest is hygiene + a nice perf bump.

---

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

---

[jonathanpeppers]

@copilot can you fix:

         CMake Error at CMakeLists.txt:32 (add_executable):
           Cannot find source file:
         
             ../../../external/termux-elf-cleaner/termux-elf-cleaner.cpp
         
           Tried extensions .c .C .c++ .cc .cpp .cxx .cu .mpp .m .M .mm .ixx .cppm
           .ccm .cxxm .c++m .h .hh .h++ .hm .hpp .hxx .in .txx .f .F .for .f77 .f90
           .f95 .f03 .hip .ispc
         
         
         CMake Error at CMakeLists.txt:32 (add_executable):
           No SOURCES given to target: elfcleaner

[Copilot]

@copilot can you fix:

         CMake Error at CMakeLists.txt:32 (add_executable):

...

Fixed in 482571e (and follow-ups). The upstream submodule renamed termux-elf-cleaner.cpp → elf-cleaner.cpp, so I updated the source path in tools/fastdev/elfcleaner/CMakeLists.txt. The new source also requires C++20 (std::counting_semaphore) and the PACKAGE_NAME/PACKAGE_VERSION/COPYRIGHT compile definitions, which I added. Verified elfcleaner now configures, builds, and runs (--version reports termux-elf-cleaner 3.0.1).

[jonathanpeppers]

@copilot more code changes required?

       (_PrepareElfCleaner target) -> 
         /mnt/vss/_work/1/s/android/external/termux-elf-cleaner/elf-cleaner.cpp(382,7): error G6BC5FD48: ‘counting_semaphore’ is not a member of ‘std’ [/mnt/vss/_work/1/s/android/tools/fastdev/fastdevtools.csproj]
         /mnt/vss/_work/1/s/android/external/termux-elf-cleaner/elf-cleaner.cpp(385,3): error GCF423A55: ‘sem’ was not declared in this scope [/mnt/vss/_work/1/s/android/tools/fastdev/fastdevtools.csproj]
         /mnt/vss/_work/1/s/android/external/termux-elf-cleaner/elf-cleaner.cpp(389,4): error G6402F897: ‘sem’ is not captured [/mnt/vss/_work/1/s/android/tools/fastdev/fastdevtools.csproj]
         /mnt/vss/_work/1/s/android/tools/fastdev/fastdevtools.targets(38,5): error MSB3073: The command ""/usr/local/lib/android/sdk/cmake/3.30.3/bin/ninja"" exited with code 1. [/mnt/vss/_work/1/s/android/tools/fastdev/fastdevtools.csproj]

    750 Warning(s)
    4 Error(s)

[Copilot]

@copilot more code changes required?

...

Yes — fixed in bbcbedd. The error means the -std=c++20 flag wasn't reaching the compiler (I reproduced the identical counting_semaphore is not a member of std locally by compiling without it). With cmake_minimum_required(VERSION 3.5), policy CMP0128 is OLD, where CMake (including the SDK's cmake 3.30.3) can omit the standard flag based on the compiler's detected default. I bumped the minimum to 3.20 so CMP0128 is NEW and the C++20 flag is always emitted. Verified locally that configure now emits -std=gnu++20 and elfcleaner builds and runs.

[Copilot]

Pull request overview

This PR updates the vendored external/termux-elf-cleaner dependency (from ee5385e to 3da3eea / v3.0.1) and adjusts the FastDev elfcleaner host-build CMake configuration so it continues to build against upstream’s renamed source file and new C++20 requirements.

Changes:

• Update cmake_minimum_required() to 3.20 and bump the C++ standard to C++20 for std::counting_semaphore.
• Update the source file path to the upstream-renamed elf-cleaner.cpp.
• Add required compile definitions (PACKAGE_NAME, PACKAGE_VERSION, COPYRIGHT) and introduce ELFCLEANER_VERSION.

[jonathanpeppers]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).